Add test that pins down the order that middleware is executed in #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2018 10:16
…d test that pins down the order that middleware is executed in
|
I'm going to do this as 2 separate PRs. First graphql-python/graphql-core#197 to give middleware its own separate test file. Then I'll revisit this branch so the diff is just focused on the new testing. |
|
Sounds good! Let me know once is ready to re-review :) |
added 3 commits
July 13, 2018 09:51
…ware_runs_in_passed_in_order
…ware_runs_in_passed_in_order
|
Merged the latest master, the diff became much smaller. Also added type annotations so @syrusakbary this is ready for re-review. |
|
Looks good. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dedicated test file for middleware (test_middleware.py) and add test that pins down the order that middleware is executed in.
This PR:
test_middleware_chain) that asserts on the order middleware is executed in, as discussed in Order of Middlewares #155. It does not change that behavior.Info about pytest's
capsyscan be found here: https://docs.pytest.org/en/latest/capture.html